[Ffmpeg-devel] [PATCH] add some h.264 fourccs to codec_bmp_tags[]

Måns Rullgård mru
Wed Nov 30 11:12:55 CET 2005


Guillaume POIRIER said:
> Hi,
>
> On 11/29/05, Corey Hickey <bugfood-ml at fatooh.org> wrote:
>> Corey Hickey wrote:
>> > These h.264 fourccs are from:
>> > http://www1.mplayerhq.hu/MPlayer/DOCS/codecs-status.html
>>
>> ...and, uh, I forgot the patch as usual.
>>
>> -Corey
>>
>>
>> Index: avienc.c
>> ==================================================================> RCS
>> file: /cvsroot/ffmpeg/ffmpeg/libavformat/avienc.c,v
>> retrieving revision 1.114
>> diff -u -r1.114 avienc.c
>> --- avienc.c    13 Nov 2005 03:32:12 -0000      1.114
>> +++ avienc.c    29 Nov 2005 22:03:25 -0000
>> @@ -77,6 +77,10 @@
>>     important if multiple tags possible for a given codec. */
>>  const CodecTag codec_bmp_tags[] = {
>>      { CODEC_ID_H264, MKTAG('H', '2', '6', '4') },
>> +    { CODEC_ID_H264, MKTAG('h', '2', '6', '4') },
>> +    { CODEC_ID_H264, MKTAG('X', '2', '6', '4') },
>> +    { CODEC_ID_H264, MKTAG('x', '2', '6', '4') },
>> +    { CODEC_ID_H264, MKTAG('a', 'v', 'c', '1') },
>>      { CODEC_ID_H264, MKTAG('V', 'S', 'S', 'H') },
>>
>>      { CODEC_ID_H263, MKTAG('H', '2', '6', '3') },
>
> This patch is trivial (and can't possibly harm) and apparently fixes a
> segfault that a mencoder used experienced.
>
> Unless anyone complains, I'll commit it tonight.

Seems fine by me.

-- 
M?ns Rullg?rd
mru at mru.ath.cx





More information about the ffmpeg-devel mailing list