[Ffmpeg-devel] qtrle bug

Mike Melanson mike
Wed Oct 26 16:57:05 CEST 2005


Reimar D?ffinger wrote:
> Hi,
> On Wed, Aug 17, 2005 at 11:07:51PM +0200, Reimar D?ffinger wrote:
> 
>>On Fri, Oct 14, 2005 at 09:06:49PM +0200, Reimar D?ffinger wrote:
>>
>>>On Wed, Oct 12, 2005 at 11:51:41AM +0200, matthieu castet wrote:
>>>
>>>>Ok, I found the bug,
>>>>
>>>>rle_code was an signed char, and when it was '*4' in the check it 
>>>>overflow and become negative.
>>>>
>>>>This patch fixes the bug.
>>>
>>>Despite the diagnosis being wrong, the patch is right I think. Can this
>>>be applied?
>>
>>Can I apply it without stepping on anyones toes? Or is some "official"
>>ffmpeg developer ready to do it?
> 
> 
> I tested it on two samples, and I can't imagine how it could break
> anything. So I will apply on Friday unless somebody speaks up.

	Go for it. At the rate anyone uses QTRLE, it will be next year before 
anyone notices any bugs.

-- 
	-Mike Melanson





More information about the ffmpeg-devel mailing list