[Ffmpeg-devel] [PATCH] Fix some gcc warnings

Aurelien Jacobs aurel
Thu Sep 22 01:05:27 CEST 2005


On Wed, 21 Sep 2005 18:28:27 -0400
Rich Felker <dalias at aerifal.cx> wrote:

> On Wed, Sep 21, 2005 at 11:40:24PM +0200, Aurelien Jacobs wrote:
> > > > So I think this patch is really desirable, and I'm willing to
> > > > apply it if no one protest.
> > > 
> > > Just make sure none of the variables are used under some #ifdef,
> > > but that doesn't appear to be the case here.
> > 
> > Yes, I verified. There was some in snow.c, so I moved them in the
> > #if 0 block.
> 
> This is not legal since they are no longer at beginning of function.
> Compiling will fail if the #if 0 is changed to #if 1.

Except if the #if 0 is just after the variable declarations, or if I
introduce a pair of { } inside of the #if 0  ;-)
Yeah, I'm aware of this gcc-2.95/C89 limitation...

Aurel





More information about the ffmpeg-devel mailing list