[Ffmpeg-devel] [PATCH] CONFIG_MUXERS

Michael Niedermayer michaelni
Thu Sep 22 10:58:47 CEST 2005


Hi

On Thu, Sep 22, 2005 at 10:44:55AM +0200, Diego Biurrun wrote:
> On Wed, Sep 21, 2005 at 11:53:13PM +0200, Michael Niedermayer wrote:
> > 
> > On Wed, Sep 21, 2005 at 11:39:12PM +0200, Diego Biurrun wrote:
> > > On Wed, Sep 21, 2005 at 11:28:45PM +0200, Michael Niedermayer wrote:
> > > > 
> > > > On Wed, Sep 21, 2005 at 11:09:49PM +0200, Diego Biurrun wrote:
> > > > > On Wed, Sep 21, 2005 at 04:03:21PM +0200, Michael Niedermayer wrote:
> > > > > > 
> > > > > > no, CONFIG_EN/DECODERS should be set depending upon if there are any 
> > > > > > *CODERS enabled, not by --disable-en/decoders
> > > > > 
> > > > > Umm, right now it is set unconditionally, my patch fixes that.
> > > > > 
> > > > > What are the semantics you are looking for?  Shouldn't
> > > > > --disable-encoders disable all individual encoders and not define
> > > > > CONFIG_ENCODERS?
> > > > 
> > > > yes, but if you disable all codecs individually CONFIG_ENCODERS should
> > > > not be set either,
> > > 
> > > That seems rather pointless to me since there is such an easy way to
> > > disable all encoders in one go (--disable-encoders)...
> > > 
> > > > this could be extended to othr things like DCT_ENCODERS
> > > > MOTION_COMPENSATING_ENCODER and so on and this then could be used to
> > > > disable various common parts of libav*
> > > 
> > > You mean that --disable-encoders should disable DCT_ENCODERS, etc as
> > > well?
> > 
> > indirectly yes but not directly, if any codec which needs *DCT is enabled
> > then CONFIG_DCT or something like that should be set
> 
> OK, but we are slowly moving away from the topic of my patches to some
> general design ideas for improving configure...
> 
> I have posted a series of simple patches that I believe to be correct
> and orthogonal to what you suggest.  OK to apply?

the CONFIG_*CODER -> CONFIG_*MUXER change is ok if it doesnt break anything
which is working currently
the "set CONFIG_EN/DECODER based only upon --disable-en/decoders" is not ok

[...]

-- 
Michael





More information about the ffmpeg-devel mailing list