[Ffmpeg-devel] [PATCH] Memory leaks...

[Martin Boehme]

Mat wrote:
>> so I'm probably not competent to comment on this. However, the fix you 
>> propose looks wrong to me because code_table gets assigned to the 
>> global variable huff_code_table[i]. So we don't want to free this 
>> memory because it's going to get used well beyond the lifetime of that 
>> loop.
> 
> You are right, I didn't watch carefully the code before, I did a fast 
> test in 10 minutes.
> huff_code_table is global... so I suppose  av_mallocz  for  code_table  
> should be  av_mallocz_static too...

I would guess so.

Martin

-- 
Martin B?hme
Inst. f. Neuro- and Bioinformatics
Ratzeburger Allee 160, D-23538 Luebeck
Phone: +49 451 500 5514
Fax:   +49 451 500 5502
boehme at inb.uni-luebeck.de