[Ffmpeg-devel] Re: [PATCH] non conformance to 3GP format (3GP TS 26.244 v 6.5.0 2006/06) 2nd try

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> On Fri, Jul 28, 2006 at 03:13:52PM +0200, ffmpeg wrote:
>> Hello,
>>
>> I would like to submit for review (and maybe integration) the following 
>> patch,
>> This is my 2nd try, now based on 5829 (trying to follow last version)
>>
>> Purpose:  Fix some non conformance to 3GP format  (3GP TS 26.244 v 6.5.0 
>> 2006/06)
>> Applies:   libavcodec/movenc.c {SVN 5720}, (test within trunk SVN 5829)
>> Testing:        - Regression test OK;
>>     - 3GP file check with some commercial 3gp analysis tools
>>     - play on QuickTime
>>     - play on HP OCMP Video 1.0
>> Authors:   Francois Draperi
>> Discussion:
>>   Some fields (like in 'samr' atom) are not set to 0; "3GP TS 26.244" 
>> enforces those values to be null.     
>>   The patch simply put 0 in the needed audio and video atom fields, for
>>   3GP files (and only them), and for AMR_NB mode (and only this codec).
>>   Maybe someone may also ask to restrict those changes to the '-strict 
>> very' mode, but is it useful ?
>> ToDo:
>>    As suggested by Baptiste C., should also applies to mp4v, mp4a, and 
>> potentially avc1. I do not know enough those, so I let someone else do 
>> the change.
> 
> patch looks ok, assuming regression tests pass, and whoever applies it 
> should also fix the indention in a second, seperate commit
> 
> [...]

Ok, here is an updated patch, which should make files conforming to all
standards, 3GP, MP4.

There are some FIXME's, does anyone have more informations that I could
not find ? Especially concerning audio > 2 channels, and compressor name
in mp4.

Michael, do you think we should keep using AVI fourcc ? The more I read
specs and the more I feel we should not do that and strictly mux
according to specs.

I'll update regression refs.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: movenc_specs_fix.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060806/b678b662/attachment.txt>