[Ffmpeg-devel] [PATCH] enable libswscale

[Diego Biurrun]

On Wed, Aug 16, 2006 at 10:03:29AM +0200, Luca Abeni wrote:
> 
> On Wed, 2006-08-16 at 00:56 +0200, Diego Biurrun wrote:
> > On Tue, Aug 15, 2006 at 01:13:33AM +0200, V?ctor Paesa wrote:
> > > 
> > > --- ffmpeg-old/libswscale/Makefile      2006-08-11 20:15:30.000000000 +0200
> > > +++ ffmpeg/libswscale/Makefile  2006-08-15 00:37:06.546875000 +0200
> > > @@ -5,6 +5,7 @@
> > >  ifeq ($(BUILD_SHARED),yes)
> > >  LIBVERSION=$(SWSVERSION)
> > >  LIBMAJOR=$(SWSMAJOR)
> > > +EXTRALIBS := -L../libavutil -lavutil$(BUILDSUF)
> > >  endif
> > 
> > This is bad, you're throwing away the contents of EXTRALIBS.
> Yes, I think it should be
> EXTRALIBS := -L../libavutil -lavutil$(BUILDSUF) $(EXTRALIBS)
> (as in the libavcodec's Makefile; I do not know why I missed it).
> If you agree, I'll commit this change this evening.

I agree.

> [*] I did not commit a copy of such file in libswscale because I hoped
> to remove this dependency in a short time. But it's summertime, and I do
> not spend much time in front of a computer. So, this is taking more time
> than expected... Maybe I should commit the copy of img_format.h? (that
> commit will remain in svn history, even when the file will be removed in
> 2 weeks or 3)

I'm not very particular about this.  If you will fix it soon I think we
can wait a bit longer.  Let others decide.

Diego