[Ffmpeg-devel] swscale recently broke (in mplayer)

[Diego Biurrun]

On Fri, Aug 18, 2006 at 02:11:59PM +0200, Diego Biurrun wrote:
> On Fri, Aug 18, 2006 at 12:15:28PM +0200, Luca Abeni wrote:
> > 
> > On Fri, 2006-08-18 at 11:53 +0200, Diego Biurrun wrote:
> > > On Fri, Aug 18, 2006 at 08:51:13AM +0200, Luca Abeni wrote:
> > > > 
> > > > while trying to check if some of my patches break swscale in mplayer, I
> > > > noticed that it already has problems compiling. It seems that the last
> > > > commit to libswscale/Makefile created build problems.
> > > 
> > > What problems exactly?  It compiles fine for me on PPC, did I break x86?
> > I did not post the error because I was under the impression that it
> > happened for everyone, but I must have missed something. Anyway, here it
> > is:
> > [...]
> > cc -c -I. -I.. -I../libvo -I../../libvo -Wdeclaration-after-statement -fno-PIC -O4 -march=prescott -mtune=prescott -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/directfb -I/usr/include -I/usr/src/DVB/ost/include  -I/usr/include/dxr2 -I/usr/local/include/cdda -I/usr/include/freetype2 -o getch2.o getch2.c
> > ar r libosdep.a shmem.o strsep.o strl.o vsscanf.o scandir.o gettimeofday.o fseeko.o swab.o setenv.o timer-lx.o getch2.o
> > ar: creating libosdep.a
> > true libosdep.a
> > make[1]: Leaving directory `/tmp/mplayer/osdep'
> > make -C libswscale LIBPREF=lib LIBSUF=.a
> > make[1]: Entering directory `/tmp/mplayer/libswscale'
> > cc -I.. -I.. -I../libavutil -I../libvo -I../../libvo -Wdeclaration-after-statement -fno-PIC -O4 -march=prescott -mtune=prescott -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/directfb -I/usr/include -I/usr/src/DVB/ost/include  -I/usr/include/dxr2 -I/usr/local/include/cdda -I/usr/include/freetype2 -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE  -c -o swscale.o swscale.c
> > swscale.c:219: error: 'IMGFMT_422P' undeclared here (not in a function)
> > [...]
> > 
> > The problem is that now "-I.." comes before "-I../libvo", so
> > mplayer/img_format.h is included (mplayer/libvo/img_format.h used to be
> > included). And that file seems to be out of synch with the other (last
> > update is 4 years ago, and it misses a lot of imgage formats ---> for
> > example, IMGFMT_422P).
> 
> Umm, there is no img_format.h in the root of the MPlayer source dir,
> there is one ine libmpcodecs/ and another one in libvo/ ...  Is that a
> local modification of yours?

.. and besides, the one in libvo/ just contains

  #include "libmpcodecs/img_format.h"

Diego