[Ffmpeg-devel] [PATCH] mpegvideo remove fourcc upper case conversion

Michael Niedermayer michaelni
Tue Aug 22 21:11:53 CEST 2006


On Tue, Aug 22, 2006 at 06:52:19PM +0200, Baptiste Coudurier wrote:
> Hi
> Here is a patch to remove uppercase conversion of fourcc. That cause
> conversion if mpeg essence is stored in container which already have a
> fourcc (mov), and IMHO a codec should not alter fourcc.

rejected, this will break decoding of many old divx and xvid files
grep for codec_tag ...

btw, speaking of breaking stuff, did you test that the unconditional
setting of AVCodecContext.width/height in the mov/mp4 demuxer has no 
negative effects if they are wrong? (they are often wrong for mpeg4)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list