[Ffmpeg-devel] libavutil conflict with system headers on Darwin

[Michael Niedermayer]

Hi

On Sun, Dec 03, 2006 at 01:39:05AM +0000, M?ns Rullg?rd wrote:
[...]
> > yes, i do prefer
> >
> > always_inline foobar(){
> >     int vector[4], i;
> >     for(i=0; i<4; i++)
> >         vector[i]= MAX(ABS(2-i), 1);
> > }
> >
> > over
> >
> > FF_always_inline foobar(){
> >     int FF_vector[4], i;
> >     for(i=0; i<4; i++)
> >         FF_vector[i]= FFMAX(FFABS(2-i), 1);
> > }
> >
> > or is it rather
> >
> > FF_always_inline foobar(){
> >     int FF_vector[4], FF_i;
> >     for(FF_i=0; FF_i<4; FF_i++)
> >         FF_vector[FF_i]= FFMAX(FFABS(2-FF_i), 1);
> > }
> >
> > what we are moving toward?
> 
> No, local variables can have any names.  Things defined by us that are
> visible outside lav* should be named that minimize the risk of
> conflicts. 

yes, of course ...


> The things in question are symbols with external linkage
> and preprocessor macros visible to apps using lav* or are defined
> before system headers are included when building ffmpeg.

no, always_inline MAX, ... should not be vissible outside they can be
redifined to (FF_always_inline, FFMAX, ...) for that and system headers
should be included before lav* headers all just IMHO

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is