[Ffmpeg-devel] [PATCH] Specify file format in vhook watermark

[Michael Niedermayer]

Hi

On Mon, Dec 04, 2006 at 12:33:39AM +0100, V?ctor Paesa wrote:
> > Hi,
> >
> > There has been some reports about images wrongly identified as MP3
> > by file probing in vhook watermark.
> >
> > To deal with that, the attached patch allows to specify explicitely
> > the file format as part of the vhook watermark invocation.
> >
> > Test A:
> > Before patch GIF is identified as MP3:
> >
> > ffmpeg -i input.avi -vhook
> > 'watermark.dll -f logo_watermark_full_layer.gif -m 0 -t ffffff' out.avi
> >
> > You get these errors:
> > [mp3 @ 0x974054]Could not find codec parameters (Audio: mp1, 160 kb/s)
> > get_watermark_picture() Failed to find stream info
> > Failed to Configure /usr/local/bin/vhook/watermark.dll
> > Failed to add video hook function: watermark.dll -f
> > logo_watermark_full_layer.gif -m 0 -t ffffff
> >
> >
> > Test B:
> > After patch you may specify the container format (image2 for GIF)
> > and no errors occur:
> >
> > ffmpeg -i input.avi -vhook
> > 'watermark.dll -F image2 -f logo_watermark_full_layer.gif -m 0 -t ffffff'
> > \
> > out.avi
> >
> > The logo GIF is at
> > http://lists.mplayerhq.hu/pipermail/ffmpeg-user/attachments/20061202/2a24b695/logo_watermark_full_layer.gif
> >
> 
> Oops, and the patch is *now* attached:

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is