[Ffmpeg-devel] Some possible libswscale cleanups?

Luca Abeni lucabe72
Thu Dec 21 17:08:56 CET 2006


Hi Aurelien,

On Thu, 2006-12-21 at 16:55 +0100, Aurelien Jacobs wrote:
[...]
> > Ughh... This is embarassing :( I just added "(type *)" without looking
> > at the code (and when I tested it "type" probably was "uint8_t").
> > I think the correct version should be
> > -			b = c->table_bU[U];\
> > +			r = (type *)c->table_rV[V];\
> > +			g = (type *)(c->table_gU[U] + c->table_gV[V]);\
> > right?
> 
> No, because here you still do arithmetic with void pointer !
Now I am really confused :)
After my patch, c->table_gU is a pointer to uint8_t, so I think it's
arithmetic with uint8_t pointers, no?


			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !





More information about the ffmpeg-devel mailing list