[Ffmpeg-devel] [PATCH] flv muxer metadata

Benjamin Larsson banan
Thu Dec 28 13:42:54 CET 2006


Michael Niedermayer wrote:

>Hi
>
>On Mon, Dec 11, 2006 at 04:14:25PM -0800, Allan Hsu wrote:
>  
>
>>On Dec 11, 2006, at 2:15 PM, Michael Niedermayer wrote:
>>[...]
>>    
>>
>>>>+const CodecTag flv_video_codec_ids[] = {
>>>>+    {CODEC_ID_FLV1,    FLV_CODECID_H263  },
>>>>+    {CODEC_ID_FLASHSV, FLV_CODECID_SCREEN},
>>>>+    {CODEC_ID_VP6F,    FLV_CODECID_VP6   },
>>>>+    {CODEC_ID_NONE,    0}
>>>>+};
>>>>+
>>>>+const CodecTag flv_audio_codec_ids[] = {
>>>>        
>>>>
>>>these 2 should either be static or have a ff_ prefix
>>>
>>>except that iam fine with the patch
>>>      
>>>
>>[...]
>>
>>Here's the same patch, but with those two tables made static.
>>    
>>
>
>still looks ok
>
>[...]
>  
>
Applied with updated regressions. Someone please test them.

MvH
Benjamin Larsson

-- 
new tiny signature





More information about the ffmpeg-devel mailing list