[Ffmpeg-devel] [PATCH] video4linux2 input

Michael Niedermayer michaelni
Wed Feb 1 11:16:10 CET 2006


Hi

On Wed, Feb 01, 2006 at 10:59:51AM +0100, Luca Abeni wrote:
> Hi,
> 
> On Tue, 2006-01-31 at 19:33 +0100, Michael Niedermayer wrote:
> [...] 
> > > So, I think I have 2 options:
> > > 1) leave "av_set_pts_info(st, 48, 1, 1000000);" as it is (and eventually
> > > provide a patch switching audio.c, grab.c & friends to 64bit pts later)
> > > or
> > > 2) change it to "av_set_pts_info(st, 64, 1, 1000000);" and change
> > > audio.c, grab.c and grab_bktr.c to 64bit pts in the v4l2.diff patch that
> > > has to be applied when committing v4l2.c
> > > 
> > > Let me know which option you prefer, and I'll send the updated files.
> > 
> > i prefer neither, they are both equal, the only bad thing would be leaving
> > them at 48 in the end :)
> Ok; I attach a new version of the v4l2.c file, that:
> - uses PixelFormat when needed
> - uses 64 bit pts
> - uses a const int for desired_video_buffers (instead of a #define)
> 
> The new v4l2.diff patch attached also changes audio.c & friends to use
> 64 bit pts, to be consistent with v4l2.c.
> 
> I hope this version can be committed to the CVS; if anyone still sees
> problems let me know and I'll do my best to address them.

looks ok, can be commited to cvs if it compiles

[...]
-- 
Michael





More information about the ffmpeg-devel mailing list