[Ffmpeg-devel] [PATCH] video4linux2 input

Erik Slagter erik
Mon Feb 6 12:22:39 CET 2006


On Sun, 2006-02-05 at 17:00 +0100, Aurelien Jacobs wrote:
> I disagree.
> It should probably read something like this:
> 
> typedef enum {
>   QCIF = 0,
>   CIF = 1,
> } res_desc_t;
> 
> if (width == 176 && height == 144)
>   return QCIF;
> else if (width == 352 && height == 288)
>   return CIF;
> else
>   return -1;

To be even more elegant, I'd use a enum AND a table. #define's for
constants are evil, indeed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2771 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060206/99abfcee/attachment.bin>



More information about the ffmpeg-devel mailing list