[Ffmpeg-devel] Patch for fixing gst-ffmpeg

[Guillaume POIRIER]

Hi,

On 1/7/06, Fabrizio Gennari <fabrizio.ge at tiscali.it> wrote:
> With GStreamer 0.10, gst-ffmpeg has become much pickier: it needs that
> all the frames are marked as I, P or B. This breaks Indeo 3 decoder, and
> possibly many others (but I haven't tested the other ones).
>
> This simple patch to ffmpeg's libavcodec fixes playing of Indeo 3 videos
> in gst-ffmpeg.
>
> diff -u -r1.3 indeo3.c
> --- libavcodec/indeo3.c 21 Apr 2005 19:01:29 -0000      1.3
> +++ libavcodec/indeo3.c 7 Jan 2006 00:28:24 -0000
> @@ -1122,6 +1122,8 @@
>      }
>      }
>
> +    s->frame.pict_type = FF_I_TYPE;
> +

This doesn't look right to me (beware, I don't know the code at all).
You're just setting pict type with a constant type, which for me means
that you're just tagging each frame with the same picture type.
If as you said each frame need to be marked as either I, P or B, this
code can't be right.

Guillaume
--
Life is pleasant. Death is peaceful. It's the transition that's troublesome.
    Isaac Asimov (1920 - 1992)

MPlayer's doc is offline. Find some fresh one here:
http://tuxrip.free.fr//MPlayer-DOCS-HTML/en/
http://tuxrip.free.fr//MPlayer-DOCS-HTML/fr/