[Ffmpeg-devel] [patch] make SONAME encoding optional

Diego Biurrun diego
Tue Jan 10 20:15:47 CET 2006


Finally got around to reviewing this...

On Sat, Dec 17, 2005 at 05:49:21PM -0800, Jacob Meuser wrote:
> the SONAME stuff is wrong for OpenBSD.  SONAMES should have both major
> and minor numbers there.  but in general, SONAMES aren't used in OpenBSD.
> 
> patch below adds a --disable-sonames option to disable SONAME encoding.
> 
> I figure this is more flexible than adding OS specific stuff.

I'm undecided about this.  Let's see...

> --- configure	17 Dec 2005 18:14:25 -0000	1.220
> +++ configure	18 Dec 2005 01:38:27 -0000
> @@ -1244,6 +1247,7 @@
>  echo "pp support       $pp"
>  echo "debug symbols    $debug"
>  echo "strip symbols    $dostrip"
> +echo "use SONAME       $dosonames"

Hmm, not every option is echoed in the configure output, I'm not sure
it's a good idea to add too much spam there.  ATM we do not seem to have
a clear policy for what gets printed and what gets skipped, though.

I'd be tempted to skip this option.  Opinions?

> @@ -215,7 +217,6 @@
>  dlfcn="no"
>  dlopen="no"
>  mpegaudio_hp="yes"
> -SHFLAGS='-shared -Wl,-soname,$@.$(LIBVERSION)'
>  netserver="no"
>  need_inet_aton="no"
>  ffserver="yes"
> @@ -1295,6 +1299,13 @@
>  echo "STRIP=echo ignoring strip" >> config.mak
>  echo "INSTALLSTRIP=" >> config.mak
>  fi
> +if test -z "$SHFLAGS" ; then
> +  if test "$dosonames" = "yes" ; then
> +  SHFLAGS='-shared -Wl,-soname,$@.$(LIBVERSION)'
> +  else
> +  SHFLAGS="-shared"
> +  fi
> +fi

I'd prefer if this could be kept where it is and overridden in the
OS-specific sections as need arises.  Then again, this probably obviates
the need for your patch.

I'm undecided.  Thoughts?

Diego





More information about the ffmpeg-devel mailing list