[Ffmpeg-devel] x264 global headers?

[Måns Rullgård]

Luca Abeni <lucabe72 at email.it> writes:

> Hello Loren,
>
> On Mon, 2006-01-16 at 12:25 -0800, Loren Merritt wrote:
> [...]
>> > I do not know how to use the x264 library, but if someone can give me
>> > some hints I can try to implement support for the
>> > CODEC_FLAG_GLOBAL_HEADER flag.
>> 
>> To tell x264 not to put the global headers in the video stream:
>>    x4->params.b_repeat_headers = 0;
>> And then get them separately:
>>    x264_encoder_headers(x4->enc, nal, nnal);
>
> Thanks for the information. So, is the attached patch correct (seems to
> work ok for me)? Can it be applied to the CVS?

I'd prefer the attached patch as it allocates a more reasonable amount
of memory for the headers.  I'm not sure how to test it, so I won't
commit until someone has confirmed that it works.

> BTW, looking at libavcodec/x264.c I see that some functions (X264_frame
> and X264_init) are declared as "extern" even if they are not used in
> other files (I think)... Shouldn't they be "static"?

Yes, they should.  Blame me.

-- 
M?ns Rullg?rd
mru at inprovide.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264-globalheader.diff
Type: text/x-patch
Size: 978 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060119/fadb7626/attachment.bin>