[Ffmpeg-devel] [PATCH] aiff/aiff-c format encoder and decoder

[Patrick Guimond]

Michael Niedermayer wrote:
> IMHO the 511 should be passed as argument and be from a sizeof to ensure no
> security bugs in case it ever decreases
> 

Fixed

>> +void put_be754_80(ByteIOContext *s, double val)
> [...]
>> +double get_be754_80(ByteIOContext *s)
> 
> these 2 dont belong in here, they should be in libavutil/intfloat_readwrite.*
> and also match the API for the float & double cases
> 

Ok, tried with a buffer supplied by the caller. I hope this is ok, is
there a better alternative?

patg


-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-aiff.patch
Type: text/x-patch
Size: 18736 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060129/308d9409/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060129/308d9409/attachment.pgp>