[Ffmpeg-devel] time for a release?
Mon Jan 30 01:05:17 CET 2006
On Sun, Jan 29, 2006 at 06:34:51PM +0100, Alexander Strasser wrote:
> Diego Biurrun wrote:
> > On Sat, Jan 28, 2006 at 01:23:02AM +0100, Alexander Strasser wrote:
> > > + Specify --enable-static to build the static libs or --enable-shared to build
> > > +the shared libs too. For only building the shared libs specify --disable-static
> > > +in addition to --enable-shared.
> > Why this strange indentation?
> It is only for readability.
Well, we disagree about this..
> > > @@ -1507,7 +1537,11 @@
> > >
> > > +if test "$lstatic" = "yes" ; then
> > > + echo "LIB=$LIB" >> config.mak
> > > +fi
> > > if test "$lshared" = "yes" ; then
> > I'd prefer if the LIB thing remained where it was, it would be clearer
> > to me.
> IMHO it is the other way around. At the position i put it
> we decide what libs to put in, it is crucial for understanding
> how the lib types get selected to be build. So if it is more
> local it is easier to grasp.
We disagree about this as well: No decision is made in the place where
you add the check.
> > > --- libavcodec/Makefile 26 Jan 2006 23:42:28 -0000 1.229
> > > +++ libavcodec/Makefile 28 Jan 2006 00:15:21 -0000
> > > @@ -422,7 +422,7 @@
> > > $(MAKE) -C libpostproc
> > > endif
> > > ifeq ($(CONFIG_WIN32),yes)
> > > - $(CC) $(SHFLAGS) -Wl,--output-def,$(@:.dll=.def) -o $@ $(OBJS) $(EXTRALIBS) $(AMREXTRALIBS)
> > > + $(CC) $(SHFLAGS) -Wl,--output-def,$(@:.dll=.def),--out-implib,lib$(SLIBNAME:$(SLIBSUF)=.dll.a) -o $@ $(OBJS) $(EXTRALIBS) $(AMREXTRALIBS)
> > This should somehow be moved to configure, it's duplicated in
> > the other Makefiles as well. The issue is unrelated to this patch,
> > though, so let's fix it separately.
> Maybe, but i agree it should not be done in this patch.
I moved it to a saner place within the Makefiles, which improves the
Since this broke your patch I've fixed it up myself and will commit it
in a few minutes. This gives me the added benefit of being able to sneak
in a few changes to make the patch suit my taste better. I hope you'll
forgive me for that :)
More information about the ffmpeg-devel