[Ffmpeg-devel] PATCH: make libavformat find codecid forAACstreams in matroska container.

[elupus]

> -----Original Message-----
> From: elupus [mailto:elupus at ecce.se] 
> Sent: den 27 januari 2006 23:26
> To: 'FFMpeg development discussions and patches'
> Subject: RE: [Ffmpeg-devel] PATCH: make libavformat find 
> codecid forAACstreams in matroska container.
> 
>  
> 
> > -----Original Message-----
> > From: Steve Lhomme [mailto:slhomme at divxcorp.com] 
> > Sent: den 27 januari 2006 20:16
> > To: FFMpeg development discussions and patches
> > Subject: Re: [Ffmpeg-devel] PATCH: make libavformat find 
> > codecid for AACstreams in matroska container.
> > 
> > elupus wrote:
> > > Hi, 
> > > 
> > > Here is a small patch to allow libavformat to find the 
> > codec on AAC streams
> > > in matroska containers. 
> > > 
> > > The defines for the AAC codec's are set like this, 
> > > 
> > > 	#define MATROSKA_CODEC_ID_AUDIO_MPEG2        "A_AAC/MPEG2/"
> > > 	#define MATROSKA_CODEC_ID_AUDIO_MPEG4        "A_AAC/MPEG4/"
> > > 
> > > which isn't the full name for the codec's. I.e. it normally 
> > has some more
> > > extension to it like MAIN, LC... 
> > > 
> > > Anyway, this patch fixes so that when the codec_id is 
> > compared to these
> > > defines, only the given length is compared (which I think 
> > was the original
> > > idea). I suppose some more information could be gotten from 
> > that extra
> > > information, but I think this should be enough.
> > > 
> > > Cheers
> > > 
> > > /Joakim
> > 
> > I provided a patch that handles this and the codec private 
> > and also the 
> > new and simple A_AAC (everything is said in the codec 
> > private). But the 
> > patch was rejected (although factorizing that code means 
> having FAAD 
> > support which is GPL).
> > 
> > You can find the code in the source releases of DrFFMPEG on 
> > SourceForge.
> > 
> > 
> > 
> 
> Took the liberty of finding this patch.. Stripped some of the compiler
> warning / int64 fixes away and I've not tried to compile it 
> right now. Just
> a RFC for now.
> 
> /Joakim
> 

Okey, cleaned out the patchs some more. Now it really should only contain
the stuff concerning AAC in mkv's. I've only tested mkv's wich has extradata
stored. I've not tested any mkv's where extradata is missing and is
generated by the extra code. Seening as it is the same code as mplayer uses
in it's demuxer, I'm fairly sure it should work.

/Joakim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: matroska.c.patch
Type: application/octet-stream
Size: 5903 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060131/faee0420/attachment.obj>