[Ffmpeg-devel] time for a release?

Michael Niedermayer michaelni
Tue Jan 31 19:29:25 CET 2006


On Tue, Jan 31, 2006 at 08:18:18AM -0500, Bryan Mayland wrote:
> Diego Biurrun wrote:
> >>[PATCH] ffserver warning cleanup 01/20/06
> >>should be checked/applied.
> >>    
> >
> >What about this one?  Mans, you are the warnings guy, can you
> >check/apply it?
> >  
> About those, Micheal Niedermayer said:
> "rejected, these silly signed/unsigned casts make the code less readable 
> feel free to send a patch which disables/filters these warnings or 
> change the actual types where its correct and possible"
> I have no other solution for the issue, considering it is a buffer used 
> as a raw unsigned byte buffer some places and as a char buffer in others 
> (depending on if ffserver is writting to http header or body).  
> Splitting the buffer into two buffers (one uint8_t, one char) would be 
> pointless, changing the type to one or the other would still give 
> warnings, and using something to disable the warnings is just a bad 
> idea.  Consider this patch dead unless someone has a better idea.

why is disabling the warning a bad idea?
could you provide a single case where it pointed to buggy code in a real
existing project? and iam just talking about the f((signed)b) style stuff
not mixing signedness in comparissions or so

and maybe "rejected" was a bit too strong, if someone of the ffmpeg devels
seriously wants the patch applied i wont object ...


More information about the ffmpeg-devel mailing list