[Ffmpeg-devel] [PATCH] video4linux2 input

[Michael Niedermayer]

Hi

On Tue, Jan 31, 2006 at 09:59:17AM +0100, Luca Abeni wrote:
> Hi Michael,
> 
> On Mon, 2006-01-30 at 18:44 +0100, Michael Niedermayer wrote:
> [...]
> > >     av_set_pts_info(st, 48, 1, 1000000); /* 48 bits pts in us */
> > 
> > why 48 and not 64
> I just discovered why: libavformat/audio.c uses 48 bits pts, so if we
> want audio and video pts to be comparable we must either use 48 bit for
> the video pts or switch the audio pts to 64 bit too.
> 
> So, I think I have 2 options:
> 1) leave "av_set_pts_info(st, 48, 1, 1000000);" as it is (and eventually
> provide a patch switching audio.c, grab.c & friends to 64bit pts later)
> or
> 2) change it to "av_set_pts_info(st, 64, 1, 1000000);" and change
> audio.c, grab.c and grab_bktr.c to 64bit pts in the v4l2.diff patch that
> has to be applied when committing v4l2.c
> 
> Let me know which option you prefer, and I'll send the updated files.

i prefer neither, they are both equal, the only bad thing would be leaving
them at 48 in the end :)

[...]
-- 
Michael