[Ffmpeg-devel] av_frac_* static?

Måns Rullgård mru
Mon Jul 3 00:19:04 CEST 2006


Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Sun, Jul 02, 2006 at 10:44:17PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > Hi
>> >
>> > On Sun, Jul 02, 2006 at 09:43:24PM +0100, M?ns Rullg?rd wrote:
>> >> Michael Niedermayer <michaelni at gmx.at> writes:
>> >> 
>> >> > Hi
>> >> >
>> >> > On Sun, Jul 02, 2006 at 08:48:08PM +0100, M?ns Rullg?rd wrote:
>> >> >> The av_frac_* functions in libavformat/utils.c were recently made
>> >> >> static by a patch from Diego Petten? (flameeyes).  I'm wondering what
>> >> >> the reason was for this change.  I thought the idea was that those
>> >> >> functions could be used throughout the library.  I'd agree that lavf
>> >> >> might not be the natural place for them, and that they could be moved
>> >> >> to libavutil/rational.c.  Opinions?
>> >> >
>> >> > why not use AVRational?
>> >> 
>> >> Not enough range.
>> >
>> > for what?
>> 
>> More than 32 bits.
>
> timestamp? use (u)int64_t,

I'll do a bit of investigation.

> timebases/framerate should fit in 32/32

You'd hope so.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-devel mailing list