[Ffmpeg-devel] swscale patch

[Michael Niedermayer]

Hi

On Mon, Jul 03, 2006 at 10:42:37AM +0200, Luca Abeni wrote:
> Hi Michael,
> 
> On Sat, 2006-07-01 at 12:39 +0200, Michael Niedermayer wrote:
> [...]
> > > Maybe we should put these macros in libavutils/x86_cpu.h (or something
> > > similar), and include such file from all the places that use REG_*?
> > > Let me know if you agree, and I will provide a patch for ffmpeg.
> > 
> > ok
> Ok, here is the patch; I hope I got it right.
> 
> The attached patch moves the REF_* macros from libavcodec/i386/mmx.h to
> libavutil/x86_cpu.h, 

ok


> and includes libavutil/x86_cpu.h from
> libavcodec/i386/mmx.h.

not ok, x86_cpu.h should be included directly from the c files, and mmx.h
removed if its unneeded which it probably is in most cases


> 
> I also added the REG_SP, REG_BP, REGBP, REGa, REGb, and REGSP macros
> that will be needed by libswscale.

ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is