[Ffmpeg-devel] [PATCH] flacenc - md5

[Luca Barbato]

Justin Ruggles wrote:
> Michael Niedermayer wrote:
>> Hi
>>
>> On Mon, Jul 03, 2006 at 02:22:33PM -0400, Justin Ruggles wrote:
>> [...]
>>
>>> I first thought of putting the lavc version in the vendor string like in
>>> the vorbis encoder, but then realized this would break regression tests
>>> at every version increment, so I just used "libavcodec" instead.  I've
>>
>> just use:
>>
>> if(!(AVCodecContext->flags & CODEC_FLAG_BITEXACT)){
>>     write full vendor string with version number
>> }
>>
>> [...]
>>
> 
> Good idea. :)
> New patch attached. With the different string lengths I had to change
> the code a bit to keep the padding the same size. The new version is
> simpler, too.
> 
> I am not 100% sure about the big-endian section in md5_accumulate.  I
> don't have a big-endian system to test on.  Just let me know if it
> doesn't work or if it could be done in a better or simpler way.

seems working ok

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero