[Ffmpeg-devel] [PATCH] enable/disable (de)muxers

Diego Biurrun diego
Mon Jul 10 00:27:24 CEST 2006


On Sun, Jul 09, 2006 at 11:10:40PM +0100, M?ns Rullg?rd wrote:
> M?ns Rullg?rd <mru at inprovide.com> writes:
> 
> > OK, here's the initial patch for review.  I'd like to have someone
> > else cast an eye on it before I commit, just in case I did something
> > really silly.
> 
> Hmm... already a flaw found.  Updated patch attached.
> 
> --- ffplay.c	(revision 5695)
> +++ ffplay.c	(working copy)
> @@ -1790,7 +1790,7 @@
>  #ifdef CONFIG_NETWORK
> -    use_play = (ic->iformat == &rtsp_demux);
> +    use_play = (ic->iformat == &rtsp_demuxer);
>  #else
> @@ -1884,7 +1884,7 @@
>          }
> -        if (is->paused && ic->iformat == &rtsp_demux) {
> +        if (is->paused && ic->iformat == &rtsp_demuxer) {
>              /* wait 10 ms to avoid trying to get another packet */

Here and below I'd prefer to see all those (semi-cosmetic) renaming
operations done in a separate patch/commit, this will shrink this patch
considerably and make it easier to review.

> --- libavformat/Makefile	(revision 5695)
> +++ libavformat/Makefile	(working copy)
> @@ -9,55 +9,153 @@
>         -D_LARGEFILE_SOURCE -D_GNU_SOURCE
>  
>  OBJS= utils.o cutils.o os_support.o allformats.o
> -CPPOBJS=

Unrelated change, commit separately.

Diego




More information about the ffmpeg-devel mailing list