[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

Diego Biurrun diego
Thu Jul 13 23:44:52 CEST 2006


On Thu, Jul 13, 2006 at 10:32:35PM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> >> --- ffmpeg-old/vhook/Makefile	2006-07-12 17:55:48.000000000 +0200
> >> +++ ffmpeg/vhook/Makefile	2006-07-13 18:07:12.968750000 +0200
> >> @@ -14,13 +21,13 @@
> >>  
> >>  ifeq ($(HAVE_IMLIB2),yes)
> >>      HOOKS += imlib2$(SLIBSUF)
> >> -    LDFLAGS += -lImlib2
> >> +    EXTRALIBS += -lImlib2
> >>  endif
> >
> > Remind me why this is necessary...
> 
> With some linkers, objects and -l options need to be in dependency
> order, and other linker flags should be at the start of the argument
> list.  LDFLAGS is passed at the start and EXTRALIBS at the end, so -l
> options go in EXTRALIBS.

Then why not simply reorder the $(CC) call?

  %$(SLIBSUF): %.o
	$(CC) $(LDFLAGS) -g -o $@ $(SHFLAGS) $<

-->

  %$(SLIBSUF): %.o
	$(CC) -g -o $@ $(SHFLAGS) $< $(LDFLAGS)

or

  %$(SLIBSUF): %.o
	$(CC) -g -o $@ $< $(SHFLAGS) $(LDFLAGS)

Looks much simpler to me...

Diego




More information about the ffmpeg-devel mailing list