[Ffmpeg-devel] libtheora brokenness in lavc

[matthieu castet]

M?ns Rullg?rd wrote:
> matthieu castet <castet.matthieu at free.fr> writes:
> 
> 
>>M?ns Rullg?rd wrote:
>>
>>>matthieu castet <castet.matthieu at free.fr> writes:
>>>Looks like a placeholder or something.  I wrote oggtheora.c, and I
>>>didn't include an encoder.
>>>
>>
>>See
>>http://article.gmane.org/gmane.comp.video.ffmpeg.devel/19311/match=nilesh
>>for more details.
> 
> 
> That patch never got applied, for whatever reason.  Some time later,
> someone wanted a libtheora wrapper, and I didn't remember or find the
> old patch, so I wrote the one that's in lavc now.
> 
Yes the main part wasn't applied, but some makefile changes were :


r3975 | michael | 2005-02-24 16:18:02 +0100 (Thu, 24 Feb 2005) | 5 lines

01-makefile_fix_updated.patch
    Adds --enable-theora/--enable-vorbis/--enable-ogg to configure
    If compiled WITHOUT --enable-theora, native VP3 decoder is used
patch by (Nilesh Bansal <nileshbansal gmail com>)

svn diff -r 3975:3974
[...]
--- libavcodec/allcodecs.c      (revision 3974)
+++ libavcodec/allcodecs.c      (revision 3975)
@@ -45,10 +45,14 @@
  #ifdef CONFIG_MP3LAME
      register_avcodec(&mp3lame_encoder);
  #endif
-#ifdef CONFIG_VORBIS
+#ifdef CONFIG_LIBVORBIS
      register_avcodec(&oggvorbis_encoder);
      register_avcodec(&oggvorbis_decoder);
  #endif
+#ifdef CONFIG_LIBTHEORA
+    register_avcodec(&oggtheora_encoder);
+    register_avcodec(&oggtheora_decoder);
+#endif
  #ifdef CONFIG_FAAC
      register_avcodec(&faac_encoder);
  #endif
[...]


So we only need to remove reference to the unimplemented theora encoder.

Matthieu