[Ffmpeg-devel] Re: [PATCH] MXF demuxer

[Baptiste Coudurier]

Hi Michael

Michael Niedermayer wrote:
>>> [...]
>>>
>>> why are there so many tables? isnt one enough?
>>>
>> Hell, no. MXF is a bloated mess.
> 
> ok
> 

All MXF is based on UID which are keys of 16 bytes. If wish I could use
int128_t. I still can build a nice table of UID recognized and use
memcmp, do you think that would be cleaner ?

I just tried to factorize and only check of variable patterns.

> [...]
> 
> imagine when you click on a save button to save several hours work which
> you did in a video editor, webpage with a little gif anim or similar
> and suddenly the shiny GUI dissapears and the commandline presents you
> with a "assert(desc->sample_rate.num % desc->sample_rate.den == 0) failed"
> and all your hard work is gone ...
> 

Hehe. I fully undertand the point here, but how this is comparable to
the asserts in mov.c checking the time_rate ?

Also about the assert checking bytes_num at the top. I have no type
bigger than int64_t in C. Im lost. I'll just stop using asserts for now
I think :>

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312