[Ffmpeg-devel] [PATCH] add skipbytes to tiny_psnr

Michael Niedermayer michaelni
Tue Jul 18 12:09:21 CEST 2006


Hi

On Tue, Jul 18, 2006 at 11:44:30AM +0200, Benjamin Larsson wrote:
[...]
> Is this patch better ?
> 
> MvH
> Benjamin Larsson
> 
> -- 
> new tiny signature
> 

> Index: tiny_psnr.c
> ===================================================================
> --- tiny_psnr.c	(revision 5778)
> +++ tiny_psnr.c	(working copy)
> @@ -106,9 +106,12 @@
>      int len= argc<4 ? 1 : atoi(argv[3]);
>      int64_t max= (1<<(8*len))-1;
>      int shift= argc<5 ? 0 : atoi(argv[4]);
> +    int skip_bytes = argc<6 ? 0 : atoi(argv[5]);
>  
>      if(argc<3){
> -        printf("tiny_psnr <file1> <file2> [<elem size> [<shift>]]\n");
> +        printf("tiny_psnr <file1> <file2> [<elem size> [<shift>] [<skip bytes>]]\n");

this is still incorrect [x] means that x is optional, so [num1] [num2] is
ambigous for the case of a single number does it mean [num1 [num2]] or [[num1] num2]
IMHO at least 

remainder is ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list