[Ffmpeg-devel] [PATCH] http_seek feature added

[I. Po]

Hi,
On 7/18/06, Michael Niedermayer <michaelni at gmx.at> wrote:

> why not move http_connect_loop before http_open so this wont be needed?
I think, it's better to move http_open to the rest of function,
declared in URLProtocol

> cosmetic change
Discarded.

> please use the same style of {} placement as the rest of the file you
> change
Fixed.

> tabs are forbidden
Fixed

I corrected the patch, but it have a side effect: if
URLContext->is_streamed field set to 0 (like in patch), ffserver fails
last step of a regression test. If I set it to 1, like before, ffmpeg
can't use seek with http protocol, but ffserver pass all tests. I
think it isn't a good idea to apply such patch, but it's better to try
to know, why ffserver fails. It's strange for me, because it means,
ffserver tryes to make some seeks in stream, if it possible. As I
understand, ffserver works through http always and previously it
doesn't seek (is_streamed was == 1).
I don't have now a solution of this trouble, so I quoted code, which
enables the seek feature, with #ifdef brackets. By default, it's
disabled.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: http.c.seek-4.patch
Type: application/octet-stream
Size: 7118 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060719/639001d4/attachment.obj>