[Ffmpeg-devel] Re: [PATCH] Intel Mac MMX/SSE2 support

[Guillaume POIRIER]

Hi,

On 7/20/06, Michael Niedermayer <michaelni at gmx.at> wrote:

> On Thu, Jul 20, 2006 at 01:16:48PM +1000, Nigel Pearson wrote:
> >       Guillaume's reworked patch seems fairly tidy to me.

The patch wasn't mine. It was provided by Nicolas Plourde.


> > Apart from one missing line of context at the end,
> > it applies cleanly to SVN r5799, and with the configure
> > workaround (no memalign), builds and almost works.
> >
> > (make test fails ...
>
> 1. nothing almost working will be applied, it has to be fully working
> 2. fix your mailer, most people hate having to search for mails with
>    similar subjects to find the patch you are talking about
> 3. ive said many times that replacing balign <-> p2align will not happen
>    this must be done with a macro and that macro must not be in a x86
>    specific file
> 4. indepenant changes must be in seperate patches (the align change is
>    such a thing)
>
> no mac-intel patches passed these trivial criteria IIRC

Nigel, Note that the idea isn't to make everything in the world so
that there's no chance that MacIntel support can be added. The idea is
that support should be clean, not disrupt too much code, and be
maintainable.

Guillaume

-- 
Do yourself and the mankind a favor and forget everything about that
abomination that is ogg.
-- Nico Sabbi
http://lists.mplayerhq.hu/pipermail/mplayer-users/2006-July/061574.html