[Ffmpeg-devel] Re: [PATCH] non conformance to 3GP format (3GP TS 26.244 v 6.5.0 2006/06)

[Baptiste Coudurier]

Hi

Diego Biurrun wrote:
> On Thu, Jul 27, 2006 at 10:40:50AM +0200, ffmpeg wrote:
>> Do you want me to remake a patch proposal with all you comments 
>> integrated, or you have already done the job?
> 
> You are expected to send an updated patch.

Yes, I investigated specs, and indeed it should be corrected.

Also, I checked the specs for mp4v, mp4a, mappings (not sure about avc1)
and it seems all those fields should be set to 0 as well.

It might be simpler and cleaner to set those fields to 0 when MODE_3GP
is set if it conforming to specs. I'll look at it, if Francois does not
beat me.

> [...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312