[Ffmpeg-devel] [PATCH] free codec extradata

Michael Niedermayer michaelni
Fri Jun 16 03:28:06 CEST 2006


Hi

On Thu, Jun 15, 2006 at 11:12:47PM +0100, M?ns Rullg?rd wrote:
> Many of the lavf demuxers allocate space in AVCodecContext.extradata,
> but only a few of them free it.  It makes sense to me to free this
> data in av_close_input_file, especially since av_find_stream_info can
> allocate it as well.  The attached patch makes this change.  Did I
> miss something, or is this not the proper way for some reason?

hmm, apply it and we will see :)


> 
> The situation is similar with the encoders in lavc.  IMHO anyone who
> allocates memory should be responsible for freeing it, except when it
> can be done some place that is common for all (such as av_close_input_file
> for demuxers).

yes agree

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list