[Ffmpeg-devel] Re: [patch] const-correctness

Baptiste Coudurier baptiste.coudurier
Sat Jun 17 17:15:04 CEST 2006


Diego Biurrun wrote:
> On Sat, Jun 17, 2006 at 02:14:51PM +0200, Baptiste COUDURIER wrote:
>> Michael Niedermayer wrote:
>>> On Sat, Jun 17, 2006 at 12:28:08AM +0200, Stefan Huehner wrote:
>>>>                                                                                 
>>>> attached patch add (mostly) const to variable and parameter declaration,        
>>>> where a char* was used and and 'const char*' should be. Additionally            
>>>> some function declarations are made static if they aren't used outside          
>>>> its declaring source file.                                                      
>>>> Only files under the libavformat directory are affected by this patch.          
>>>>                                                                                 
>>>> Please review and consider for inclusion.                                       
>>> patch looks ok assuming it compiles & regression tests pass ...
>> Compiles fine and pass regression tests here.
> 
> What's stopping you from committing it then? :)
> 

Another test from someone on another arch maybe ? :)

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312




More information about the ffmpeg-devel mailing list