[Ffmpeg-devel] [PATCH] First small fix for compiler warnings in snow.c

Pieter Hollants pieter
Sun Jun 25 17:06:36 CEST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In snow.c's get_4block_rd(), line 3166 reads "static DWTELEM
zero_dst[4096]; //FIXME". This zero_dst is passed in a call to
add_yblock() in line 3182, which triggers a compiler warning about the
const qualifier being left-off.

Now add_yblock, which begins in line 2684, actually modifies dst (which
in this case is a reference to zero_dst) in the #if 0 / #else / #endif
blocks at the end of the function. Therefore: shouldn't the "const"
qualifier be removed from the variable declaration as in the attached
small patch?

- --
Pieter "Fate" Hollants <pieter at hollants.com>
(a current GnuPG key is available at www.hollants.com/gnupg.txt)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEnqZ8a8/cc5b1WpwRApkzAJ9LCoQNx1LAVwAzxhdHMCLlZsYSmgCfcbh0
V+2SDvwnruQlNoXK7PG6ZWk=
=q5Fu
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dsputil_warn.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060625/648ca05b/attachment.asc>



More information about the ffmpeg-devel mailing list