[Ffmpeg-devel] [PATCH] 3DNow! version of FFT

[Michael Niedermayer]

Hi

On Mon, Mar 06, 2006 at 07:53:24PM -0800, Corey Hickey wrote:
> Zuxy Meng wrote:
> > Hi,
> > 
> > Attached are the 3DNow! & Extended 3DNow! versions of FFT, as a
> > replacement for ff_fft_calc_sse on K6/7 CPUs.
> > 
> > Like fft_sse.c, they are written in instrinsics and require mm3dnow.h.
> > Proper configure script diff detecting this header is also included.
> 
> [cut]
> 
> > --- ffmpeg/libavcodec/i386/fft_3dn.c	1970-01-01 08:00:00.000000000 +0800
> > +++ ffmpeg.new/libavcodec/i386/fft_3dn.c	2006-03-07 08:29:13.000000000 +0800
> > @@ -0,0 +1,138 @@
> > +/*
> > + * FFT/MDCT transform with 3DNow! optimizations
> > + * Copyright (c) 2002 Fabrice Bellard.
> > + * Copyright (c) 2006 Zuxy MENG Jie.
> 
> I was about to apply this, but then I noticed the lines above. Should
> Fabrice's copyright really be on two new fft_3dn files? I gather they
> both started out as copies of fft_sse.c, but I don't know what standard
> operating procedure is in this case. Either way, having "2002" in a
> brand new file seems misleading to me. Something like this might be better:
> 
> * Copyright (c) 2006 Zuxy MENG Jie.
> * Based on fft_sse.c copyright (c) 2002 Fabrice Bellard.
> 
> ...or words to that effect.

short awnser: who cares?!

long awnser:
iam not qualified to awnser that, please go and ask a lawyer 
/me will train bogofilter on this legalese spam

[...]
-- 
Michael