[Ffmpeg-devel] [PATCH] dv pixel format encoding fix

Baptiste COUDURIER baptiste.coudurier
Thu Mar 9 17:13:11 CET 2006


Hi,

Here is a patch to fix pixel format while encoding in dv.

SMPTE 314M defines 411P and 422P, and specifies atp as 1. Appendix A
shows that IEC 61834 used 0 as atp. SMPTE 314 specifies STYPE to be 1
for 422P and 0 for 411P, I assume 420 is 0.

http://www.smpte.org/smpte_store/standards/pdf/s314m.pdf

That fixes pix_fmt detection on most dv streams.
I still have problems with DV in MOV since I could not figure out yet
where atp is set in codec encoding functions. Roman could you help me on
this one ?

It seems since you removed the profile check, encoding with incorrect
pix_fmt or resolution produces 0 bytes frames.

I think that this check should really be resurrected until codec
restrictions are handled differently, at least for encoder, else it's
hard to figure out that something went wrong, what do you think ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dv_pix_fmt_fix.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060309/2767e75c/attachment.txt>



More information about the ffmpeg-devel mailing list