[Ffmpeg-devel] [RFC, PATCH] import libswscale

[Luca Abeni]

Hi Michael,

On Wed, 2006-03-22 at 10:31 +0100, Michael Niedermayer wrote:
[...]
> > Is it ok to define an extended version of img_resample_init() (accepting
> > "flags" as a parameter? If yes, then the SWS_* constants mentioned above
> > should be moved from swscale.h to libavcodec.h. Is this acceptable?
> 
> hmm, IMHO swscale.h could be installed along with avcodec.h
> iam also starting to tend more toward using the swscale interface then
> the img_* interface from ffmpeg.c, ...
Ok, in the next patch I'll modify ffmpeg.c to directly using the swscale
interface (defining it in terms of img_resample() if swscale is not
configured in)...

[...]
> > diff -urp /home/niagara/SwS/main/postproc/rgb2rgb.h /home/niagara/SwS/internal/libswscale/rgb2rgb.h
> > --- /home/niagara/SwS/main/postproc/rgb2rgb.h	2005-10-12 14:11:27.000000000 +0200
> > +++ /home/niagara/SwS/internal/libswscale/rgb2rgb.h	2006-03-21 10:16:53.000000000 +0100
> > @@ -132,11 +132,11 @@ static void yuv2rgb(uint8_t * image, uin
> >  			      uint8_t * pu, uint8_t * pv,
> >  			      unsigned h_size, unsigned v_size,
> >  			      int rgb_stride, int y_stride, int uv_stride){
> > -printf("broken, this should use the swscaler\n");
> > +    av_log(NULL, AV_LOG_ERROR, "broken, this should use the swscaler\n");
> >  }
> >  
> >  static void yuv2rgb_init (unsigned bpp, int mode){
> > -printf("broken, this should use the swscaler\n");
> > +    av_log(NULL, AV_LOG_ERROR, "broken, this should use the swscaler\n");
> >  }
> 
> why not simply remove yuv2rgb_init() and yuv2rgb() ...
Ok, I'll remove them

[...]
> > -#define MSG_INFO(args...) mp_msg(MSGT_SWS,MSGL_INFO, ##args )
> > +#define MSG_WARN(args...) av_log(NULL, AV_LOG_DEBUG, ##args )
> > +#define MSG_FATAL(args...) av_log(NULL, AV_LOG_ERROR, ##args )
> > +#define MSG_ERR(args...) av_log(NULL, AV_LOG_ERROR, ##args )
> > +#define MSG_V(args...) av_log(NULL, AV_LOG_INFO, ##args )
> > +#define MSG_DBG2(args...) av_log(NULL, AV_LOG_DEBUG, ##args )
> > +#define MSG_INFO(args...) av_log(NULL, AV_LOG_INFO, ##args )
> 
> we also should change NULL to the sws context at some point in the future
Ok, noted. This means that we should modify the sws context to include
an AVClass as a first member, right?

			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Logos Finanziaria SPA. Societ? di credito ad erogazione diretta. Fino a 30.000 euro in 24 ore! Clicca e scopri come
* 
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=2909&d=22-3