[Ffmpeg-devel] [PATCH] X264_INC and XVID_INC are ignored

[Derek E. Lewis]

Ah, I see what you're saying.  Indeed, it's not an ffmpeg problem, since 
ffmpeg doesn't make use of XVID_INC, XVID_LIB, X264_INC, or X264_LIB -- 
the problem is with MPlayer making use of them, and fooling the user into 
using --with-xvidincdir, etc., rather than specifying additional CFLAGS 
and LDFLAGS.  Forget about this patch. :-)

Thanks,

Derek E. Lewis
dlewis at solnetworks.net
http://riemann.solnetworks.net/~dlewis

On Wed, 22 Mar 2006, [iso-8859-1] M?ns Rullg?rd wrote:

> "Derek E. Lewis" <dlewis at solnetworks.net> writes:
>
>> On Wed, 22 Mar 2006, [utf-8] M?ns Rullg?rd wrote:
>>
>>>
>>> Derek E. Lewis said:
>>>> For those of us that install X264 or XviD into ``non-standard''
>>>> locations, the libavcodec/Makefile fails to make use of the
>>>> XVID_INC and X264_INC that may be specified at configure-time.  A
>>>> patch has been attached.
>>>
>>> IMHO using --extra-cflags and --extra-ldflags should be preferred.
>>>
>> Then why are X264_INC or XVID_INC even being used?  I'm not saying I
>> disagree with you, but X264_INC and XVID_INC are being used in other
>> Makefiles, but no in the libavcodec/ one.  This is an inconsistency.
>
> Where are they used?  I can't find either of those mentioned in any
> file in the ffmpeg tree.
>
> If this is an mplayer thing it should be fixed in mplayer's configure
> script, not here.
>
> -- 
> M?ns Rullg?rd
> mru at inprovide.com
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
>
>