[Ffmpeg-devel] movenc.c ipod h264 suggested change

[Michael Niedermayer]

Hi

On Tue, Mar 28, 2006 at 11:26:13PM -0500, Jason Millard wrote:
> Okay attached are changes to ffmpeg.c and movenc.c based upon Michael
> and Loren's comments.
> 
> I must say I'm puzzled, because I'm confused on how to get profile and
> level over the way you wanted.
> 
> So I made the code match the other options.
> 
> I'm just not sure when AVCodecContext gets filled with information,
> ie. say I went
> 
> -target ipod -profile 51 -level 30
> 
> or
> 
> -profile 51 -level 30 -target ipod
> 
> I'm not sure if my implementation squashes -profile and -level args.

it probably does, the issue is that theres a old and new way to set options
the old one has the variables in ffmpeg.c the new uses AVOptions

instead of video_profile = 66; / video_level = ...
you should write, opt_default("profile", "66"); / ...
this also means significantly fewer changes to ffmpeg.c

and i assume loren is ok with using the raw values for level & profile?
not sure if theres a better aproach anyway ...

[...]

-- 
Michael