[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Diego Biurrun]

Do not compose messages by replying to unrelated messages, it breaks
threading.

On Mon, May 01, 2006 at 12:24:45AM +0200, V?ctor Paesa wrote:
> 
> I would like to submit for your consideration two patches:
> 
> a) Add vhook support to Cygwin
> http://usuarios.arsystel.com/wzrlpy/ffmpeg/ffmpeg.cygwin.vhook.1.patch

Please just attach such small patches.  It makes the review process
easier because people can comment on individual parts of the patch
easily.

Why do you want to install the shared libs in $(bindir)?
Why do you use EXTRALIBS instead of SHFLAGS in vhook/Makefile?

> I know that making changes in ffmpeg to workaround compiler bugs is not 
> very popular, but I would like to adventure this second patch:
> 
> b) Always compile avformat statically under Cygwin
> http://usuarios.arsystel.com/wzrlpy/ffmpeg/ffmpeg.cygwin.static_avformat.1.patch

I don't see how this has any advantage over just using --enable-static.
Patch rejected unless you come up with a really good explanation.

Diego