[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

Víctor Paesa wzrlpy
Mon May 1 21:18:51 CEST 2006


Hi,

>Do not compose messages by replying to unrelated messages, it breaks
>threading.
Sorry, I thought threading was based just on subject.

>Please just attach such small patches.  It makes the review process
>easier because people can comment on individual parts of the patch
>easily.
Well, I don't trust that my Hotmail account sends just ASCII, so I made the 
patch available via a link.


>Why do you want to install the shared libs in $(bindir)?
It's the Cygwin way, DLLs are together with EXEs in the same directory, and 
import libraries for DLLs  are in $(libdir).

>Why do you use EXTRALIBS instead of SHFLAGS in vhook/Makefile?
In Cygwin the order of libraries is important, the linker wants the 
libraries you depend on at the rightmost position in the command line.

> > b) Always compile avformat statically under Cygwin
> > 
>http://usuarios.arsystel.com/wzrlpy/ffmpeg/ffmpeg.cygwin.static_avformat.1.patch
>
>I don't see how this has any advantage over just using --enable-static.
>Patch rejected unless you come up with a really good explanation.
By this second patch the vhooks size tops at about 200KB, if I use 
--enable-static, then vhooks increase to about 3MB.

Regards,
V?ctor






More information about the ffmpeg-devel mailing list