[Ffmpeg-devel] [PATCH] mpeg2 intra vlc support

Michael Niedermayer michaelni
Thu May 11 23:26:55 CEST 2006


On Mon, May 08, 2006 at 11:29:46PM +0200, Baptiste COUDURIER wrote:
> Hi,
> This patch adds support for intra vlc use in mpeg2.
> Few comments : is uni_mpeg1_ac_vlc_bits used anywhere ? If not could it
> be removed to simplify init_uni_ac_vlc ?

hmm, it indeed seems unused, so yes feel free to remove it

> Only difference between rl_mpeg1 and rl_mpeg2 is table_vlc ? Is the
> change correct ? 

does it work? if yes then ill assume it ok
btw, maybe we should change one of the existing regression tests so that
we have one which uses the new vlc table

> Should I still use rl table or simplify by only
> changing one variable pointing to the vlc table ?


> Parameter is not added yet, is a "ilvc" option with and intra_vlc field
> in AVCodecContext ok ?

iam more in favor of a CODEC_FLAG2_INTRA_VLC as that fits better into
how similar parameters are passed ...

except these, patch ok



In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list