[Ffmpeg-devel] Re: [PATCH] mpeg2 intra vlc support
Sat May 13 19:18:26 CEST 2006
Michael Niedermayer wrote:
> On Mon, May 08, 2006 at 11:29:46PM +0200, Baptiste COUDURIER wrote:
>> This patch adds support for intra vlc use in mpeg2.
>> Few comments : is uni_mpeg1_ac_vlc_bits used anywhere ? If not could it
>> be removed to simplify init_uni_ac_vlc ?
> hmm, it indeed seems unused, so yes feel free to remove it
>> Only difference between rl_mpeg1 and rl_mpeg2 is table_vlc ? Is the
>> change correct ?
> does it work? if yes then ill assume it ok
> btw, maybe we should change one of the existing regression tests so that
> we have one which uses the new vlc table
Added regression tests. As expected, out.yuv is similar.
>> Should I still use rl table or simplify by only
>> changing one variable pointing to the vlc table ?
>> Parameter is not added yet, is a "ilvc" option with and intra_vlc field
>> in AVCodecContext ok ?
> iam more in favor of a CODEC_FLAG2_INTRA_VLC as that fits better into
> how similar parameters are passed ...
> except these, patch ok
Did -flags2 +ivlc and checked for CODEC_ID_MPEG2VIDEO us
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A. http://www.smartjog.com
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
More information about the ffmpeg-devel