[Ffmpeg-devel] [PATCH] [RFC] configure cleanup

Måns Rullgård mru
Wed May 31 00:26:55 CEST 2006


Rich Felker <dalias at aerifal.cx> writes:

> On Tue, May 30, 2006 at 11:14:27PM +0100, M?ns Rullg?rd wrote:
>> Hi,
>> 
>> Here's a patch that cleans up the configure script a fair bit.  It
>> works for me, but I'd like for some more people to test it before I
>> commit it.  I'm particularly interested in feedback from people with
>> non-Linux OSes.
>> 
>> -- 
>> M?ns Rullg?rd
>> mru at inprovide.com
>
>> Index: configure
>> ===================================================================
>> --- configure	(revision 5434)
>> +++ configure	(working copy)
>> @@ -96,6 +96,52 @@
>>    exit 1
>>  }
>>  
>> +check_cc(){
>> +    cat >$TMPC
>> +    ${cross_prefix}$cc "$@" -c -o $TMPO $TMPC $CFLAGS $LDFLAGS >/dev/null 2>&1
>> +}
>> +
>> +check_ld(){
>> +    cat >$TMPC
>> +    ${cross_prefix}$cc "$@" -o $TMPE $TMPC $CFLAGS $LDFLAGS >/dev/null 2>&1
>> +}
>
> All options should appear before non-option arguments,

That breaks with single-pass linkers that only look in libraries for
thus far encountered undefined symbols.

> and $LIBS or equivalent should appear at the end, in commands line
> this.

Well, there is no $LIBS in the ffmpeg configure script.  I don't
understand what you're trying to say.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-devel mailing list