[Ffmpeg-devel] [PATCH] cosmetic

Steve Lhomme slhomme
Wed Nov 1 22:06:58 CET 2006


Aurelien Jacobs wrote:
> On Wed, 01 Nov 2006 21:37:08 +0100
> Steve Lhomme <slhomme at divxcorp.com> wrote:
> 
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Tue, Oct 24, 2006 at 04:24:45PM +0200, Steve Lhomme wrote:
>>>> Hi,
>>>>
>>>> This patch just fix the indentation in some parts of the code.
>>>>
>>>> Steve
>>>> Index: libavcodec/g726.c
>>>> ===================================================================
>>>> --- libavcodec/g726.c	(revision 6775)
>>>> +++ libavcodec/g726.c	(working copy)
>>> [...]
>>>> +    int* F;               /**< special table #2 */
>>> [...]
>>>> -         int pk[2];           /**< signs of prev. 2 sez + dq */
>>>> +     Float11 sr[2];       /**< prev. reconstructed samples */
>>> this doesnt look correct
>> If you cut the patch, of course it doesn't look right. The last line 
>> doesn't replace the line just above but many lines above...
> 
> The cut was intentionnal and pretty clear. Notice the "int* F;".
> 
>> If you look at the patch in its entirety, it's fine.
> 
> No, it's wrong.
> The point is that the following two lines don't have the same indentation:
> +    int* F;               /**< special table #2 */
> +     Float11 sr[2];       /**< prev. reconstructed samples */

Thanks for clarifying... Here's a fixed patch.

Steve

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cosmetic.v2.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061101/ad6aeda6/attachment.txt>



More information about the ffmpeg-devel mailing list