[Ffmpeg-devel] [PATCH] targa rgba32 support
Kostya
kostya.shishkov
Fri Nov 3 05:43:37 CET 2006
On Thu, Nov 02, 2006 at 02:40:44PM +0100, Baptiste Coudurier wrote:
> Hi
>
> This patch activates rgba32 support for targa. Kostya do you want the
> sample ?
Yes. But your patch is not correct because it lacks RLE support and
does it work as supposed on big-endian? You may need to use PIX_FMT_RGBA
here instead.
> Also change error message to actually print what's in the file.
Actually that should be done in separate patch. Applied that part.
>
> --
> Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
> SMARTJOG S.A. http://www.smartjog.com
> Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> Phone: +33 1 49966312
> Index: libavcodec/targa.c
> ===================================================================
> --- libavcodec/targa.c (revision 6868)
> +++ libavcodec/targa.c (working copy)
> @@ -128,8 +128,11 @@
> case 24:
> avctx->pix_fmt = PIX_FMT_BGR24;
> break;
> + case 32:
> + avctx->pix_fmt = PIX_FMT_RGBA32;
> + break;
> default:
> - av_log(avctx, AV_LOG_ERROR, "Bit depth %i is not supported\n", avctx->bits_per_sample);
> + av_log(avctx, AV_LOG_ERROR, "Bit depth %i is not supported\n", s->bpp);
> return -1;
> }
>
More information about the ffmpeg-devel
mailing list