[Ffmpeg-devel] [RFC] Fraps v2 support

[Kostya]

On Thu, Nov 02, 2006 at 07:52:23PM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Thu, Nov 02, 2006 at 08:24:46PM +0200, Kostya wrote:
> > Please test if patch attached confirms to $subj. I have only a bit of one
> > sample here.
> 
> [...]
> 
> > +    cur_node = 510; // for futher use in huffman decoding
> > +    /* we have built Huffman table and are ready to decode plane */
> > +    /* XXX this bitreader ignores every 32th bit so lavc bitreader cannot be used*/
> 
> hmm i can belive it ... are you sure that they ignore every 32th bit??
> if its really true then id suggest that you use a temporary buffer and 
> convert that 31/32bit block stream to a normal one, i guess that this 
> with the get_vlc() code from lavc  is still faster ...

I could not believe this too but it worked. I'll redo it with buffer. 

[...]
> > +            /* we need to add 0x80 to the first line of the chroma planes */
> > +            if(!j && Uoff) dst[i] += 0x80;
> > +            /* lines are stored as deltas between previous line */
> > +            if(j) dst[i] += dst[i - stride];
> 
> id suggest
> 
> if(j) ...
> else if(Uoff) ...

Why not
 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> In the past you could go to a library and read, borrow or copy any book
> Today you'd get arrested for mere telling someone where the library is
>